Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error checking code and fix sql script #4041

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

javfg
Copy link
Collaborator

@javfg javfg commented Jul 5, 2023

No description provided.

@gmgigi96 gmgigi96 marked this pull request as ready for review July 6, 2023 07:58
@gmgigi96 gmgigi96 requested review from labkode, gmgigi96, glpatcern and a team as code owners July 6, 2023 07:58
pkg/notification/db_changes.sql Outdated Show resolved Hide resolved
@glpatcern glpatcern self-requested a review July 10, 2023 15:58
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the actual schema change on the oc_share we quickly discussed, this is so far OK

@gmgigi96 gmgigi96 merged commit b38215d into cs3org:master Jul 11, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants