Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openapi 3 #83

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Openapi 3 #83

wants to merge 4 commits into from

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Apr 18, 2024

I was confused by the examples for /share and converted the spec from swagger to openapi which allows using multiple examples. IMO we should update to openapi to better document how the api should be used.

This PR consists of four commits:

  1. convert to openapi v3 (it explicitly uses application/hal+json for a lot of responses, but I don't know how critical that is)
  2. use multiple share examples
  3. use multiple notification examples
  4. deprecate protocol options property

Let me know what you think.

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
Copy link
Contributor Author

butonic commented Apr 18, 2024

urgh, now I see #64

@glpatcern
Copy link
Member

urgh, now I see #64

I think we can close that one that is now outdated, and concentrate on this one.

@glpatcern glpatcern mentioned this pull request May 2, 2024
@glpatcern
Copy link
Member

@butonic could you please rebase this? I think it's very valuable at this stage - and with no outstanding change/tuning of the specs - to move to OpenAPI. And we could then envisage to tag OCM v1.2.0.

@mickenordin
Copy link
Collaborator

Current version of spec can easily be converted to openapi 3 using the following command:

npx -p swagger2openapi swagger2openapi https://raw.githubusercontent.com/cs3org/OCM-API/develop/spec.yaml --outfile spec.yaml -t 3.0.3

@glpatcern glpatcern mentioned this pull request Aug 22, 2024
@michielbdejong
Copy link
Contributor

I ran that and pushed it to the openapi3 branch. Does https://cs3org.github.io/OCM-API/docs.html?branch=openapi3&repo=OCM-API&user=cs3org#/paths/~1invite-accepted/post look OK? If so we can switch to it!

@glpatcern glpatcern self-requested a review September 4, 2024 07:24
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran that and pushed it to the openapi3 branch. Does https://cs3org.github.io/OCM-API/docs.html?branch=openapi3&repo=OCM-API&user=cs3org#/paths/~1invite-accepted/post look OK? If so we can switch to it!

Well, again we have quite a number of ongoing PRs, and this branch is already in conflict with the current HEAD. I'd postpone this until we settle them (and before tagging 1.2).

@glpatcern glpatcern marked this pull request as draft September 6, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants