Windows CI for Slither #1137
Merged
Windows CI for Slither #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardcoded, manually-installed version is out of date. This updates the workflow to install directly from pip now that it is available there.
This version introduces Windows support.
This enables runs on windows-2022 and updates solc-select to support running on Windows.
This enables runs on windows-2022 and updates solc-select to support running on Windows.
Disable fail-fast so failures in one platform do not hide failures in the other OS.
Backslashes are escaped in the string representation, so we need to double them before replacing. Also change generic path to a constant string to avoid it being converted to "\GENERIC_PATH" in Windows and getting an invalid escape error from the JSON decoder later on.
If autocrlf is enabled on Windows, it will rewrite solc code with CRLF file endings and break tests that depend on byte offsets in the code files.
This enables runs on windows-2022 and updates solc-select to support running on Windows. Some tests with Linux requirements are excluded.
v1 does not install Python correctly on Windows. While at it, update all instances to v3.
|
This pull request introduces 1 alert when merging 7097bc1 into 81daa56 - view on LGTM.com new alerts:
|
elopez
force-pushed
the
windows-ci
branch
10 times, most recently
from
cf86e04
to
7740268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Windows into Slither's CI workflows. In the process of doing so, it also fixes several issues that affect execution of Slither and/or tests in the Windows OS.