Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user defined types #1135

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Add support for user defined types #1135

merged 4 commits into from
Mar 22, 2022

Conversation

montyly
Copy link
Member

@montyly montyly commented Mar 18, 2022

This is a WIP - the main blocker is how to handle warp operations without adding too much complexity to the parsing.

- Create a new core object TypeAlias (top level or contract)
- Add support for wrap/unwrap
- Add tests
@montyly
Copy link
Member Author

montyly commented Mar 21, 2022

Related: #951
Fix : #1026

@lgtm-com
Copy link

lgtm-com bot commented Mar 21, 2022

This pull request introduces 3 alerts when merging 4b16949 into c079206 - view on LGTM.com

new alerts:

  • 2 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization

@lgtm-com
Copy link

lgtm-com bot commented Mar 21, 2022

This pull request introduces 3 alerts when merging bde2183 into c079206 - view on LGTM.com

new alerts:

  • 2 for `__eq__` not overridden when adding attributes
  • 1 for Missing call to `__init__` during object initialization

@montyly montyly marked this pull request as ready for review March 21, 2022 15:49
@lgtm-com
Copy link

lgtm-com bot commented Mar 21, 2022

This pull request introduces 2 alerts when merging 04efd72 into 496c8e1 - view on LGTM.com

new alerts:

  • 1 for Missing call to `__init__` during object initialization
  • 1 for Inconsistent equality and hashing

@montyly montyly merged commit 5863c30 into dev Mar 22, 2022
@montyly montyly deleted the dev-user-defined-types branch March 22, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant