Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added an example for update function in OpenSSL::Digest #7918

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added an example for update function in OpenSSL::Digest #7918

wants to merge 3 commits into from

Conversation

curioustolearn
Copy link

No description provided.

@curioustolearn curioustolearn changed the title Example of update function in OpenSSL::Digest Added an example for update function in OpenSSL::Digest Jun 23, 2019
Sija
Sija reviewed Jun 23, 2019
View reviewed changes
src/openssl/digest/digest.cr Outdated Show resolved Hide resolved
@curioustolearn @Sija
Update src/openssl/digest/digest.cr
cf5bc7f 
Co-Authored-By: Sijawusz Pur Rahnama <[email protected]>
@oprypin
Copy link
Member

oprypin commented Jun 24, 2019

This seems to be incorrect, though? update clearly returns self, not a string.

ysbaddaden
ysbaddaden requested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. Update is used to append strings to encode, then you must call a method to get a slice (digest) or a string (hexdigest, base64digest).

@straight-shoota straight-shoota added kind:docs pr:needs-work A PR requires modifications by the author. topic:stdlib:crypto labels Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@ysbaddaden ysbaddaden ysbaddaden requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind:docs pr:needs-work A PR requires modifications by the author. topic:stdlib:crypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@curioustolearn @oprypin @Sija @ysbaddaden @straight-shoota @bharatbhole