Regression: Socket#connect with number timeout (deprecated) #14753
Conversation
ysbaddaden
added
topic:stdlib:networking
kind:regression
| @@ -114,6 +114,11 @@ class Socket < IO | |||
| yield result if result.is_a?(Exception) | |||
| end | |||
|
|
|||
| @[Deprecated("Use `#connect(addr, Time::Span?, &)` instead.")] | |||
There was a problem hiding this comment.
Wouldn't this mean the warning will say to use the block version even if you're using the blockless version?
There was a problem hiding this comment.
I copied the other messages, but the deprecation message should be personalized I guess. Maybe?
Use
Time::Spanfor timeouts instead.
There was a problem hiding this comment.
Ideally each overload would have a warning specific to that overload. But also should make sure using the blockless overload doesn't trigger a warning for both since it delegates to the block version.
|
This doesn't really work out well without adding type restrictions to the |
fixes #14752