Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GC.malloc for gc_none to clear memory #14746

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Fix GC.malloc for gc_none to clear memory #14746

merged 1 commit into from
Jul 1, 2024

Conversation

straight-shoota
Copy link
Member

Resolves #14678

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:runtime labels Jun 24, 2024
@straight-shoota straight-shoota self-assigned this Jun 24, 2024
@straight-shoota straight-shoota added this to the 1.13.0 milestone Jun 28, 2024
@straight-shoota straight-shoota merged commit 70ed2d0 into crystal-lang:master Jul 1, 2024
61 checks passed
@straight-shoota straight-shoota deleted the fix/gc-none-malloc-clear branch July 1, 2024 10:02
straight-shoota added a commit that referenced this pull request Jul 2, 2024
@straight-shoota
Fix GC.malloc for gc_none to clear memory (#14746)
f3b5a6a 
`GC.malloc` is supposed to clear the memory, but libc `malloc` does not do this. So we need to add it explicitly.
@BrewTestBot BrewTestBot mentioned this pull request Jul 10, 2024
Merged
1 task
@HertzDevil HertzDevil mentioned this pull request Jul 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees

@straight-shoota straight-shoota

Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:runtime
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

GC.malloc doesn't clear memory (as specified) for gc_none
2 participants
@straight-shoota @ysbaddaden