Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ameba linter #14631

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

Sija
Copy link
Contributor

@Sija Sija commented May 26, 2024

Resolves #14608

@Sija Sija force-pushed the enable-ameba-linter branch 3 times, most recently from e419809 to 3dc1063 Compare May 26, 2024 21:08
@Sija
Copy link
Contributor Author

Sija commented May 26, 2024

I've managed to get it running after a few tries - GHA don't allow GITHUB_TOKEN secret usage unless the proper permissions are given (see this SO question for example), so for the time being I've circumvented the problem by using a locally installed version, so we can see the actual output.

Finished in 51.78 seconds
2041 inspected, 373 failures

@Sija
Copy link
Contributor Author

Sija commented May 27, 2024

I've cooked a config file which disables the biggest offenders and (most likely) unwanted rules.
Next steps I can think of are as follows:

  1. Scrutinize current .ameba.yml config file choices
  2. Triage existing issues
  3. Discern between the issues to correct and the ones to ignore
  4. Act accordingly

@straight-shoota
Copy link
Member

What do you need GITHUB_TOKEN secret for?

@Sija
Copy link
Contributor Author

Sija commented May 28, 2024

@straight-shoota Ameba's github action needs it.

@ysbaddaden
Copy link
Contributor

@straight-shoota It needs the token to report Ameba issues as comments on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable ameba in this repo
3 participants