Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade depencencies #126

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Upgrade depencencies #126

merged 1 commit into from
Sep 19, 2020

Conversation

elbywan
Copy link
Contributor

@elbywan elbywan commented Sep 19, 2020

Description

This PR updates all the dependencies, most notably:

  • removes the deprecated vscode package and replaces it with the up-to-date @types/vscode and vscode-test packages.
  • updates the language server client to support the new features

Why?

I am currently writing Crystalline, a Crystal LSP server and I need a client that has progress support. Unfortunately with the current outdated dependencies this is not the case as of today, hence this PR.

@max-bertinetti max-bertinetti merged commit c46ed24 into crystal-lang-tools:master Sep 19, 2020
@max-bertinetti
Copy link
Contributor

Hi @elbywan, thank you for your PR.

Can I just ask why Crystalline? What's the differences with Scry? Can we speak about it?

@elbywan
Copy link
Contributor Author

elbywan commented Sep 19, 2020

Hi @maxbertinetti,

Thanks for merging the PR!

Can I just ask why Crystalline? What's the differences with Scry? Can we speak about it?

Good timing I just wrote a forum post about it 😄.

Well Scry has never been working for me, and I did not see anyone working on it to improve the situation. So I decided to rewrite the whole thing from scratch (to be honest I maybe reused 50 lines of code from Scry).

@max-bertinetti
Copy link
Contributor

Do you like Crystalline included in this organisation (I need to speak with some people for that to happen, but just to be sure is something that you can like)?

Many ppl ask about Scry improvement but I don't know anyone directly involved in it actually. I think that can be interesting to collaborate so that VS Code / Crystalline / Ameba can become a defacto standard for developing Crystal for v.1.0.0 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants