Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hacl star #461

Merged
merged 11 commits into from
Jun 18, 2024
Merged

update hacl star #461

merged 11 commits into from
Jun 18, 2024

Conversation

franziskuskiefer
Copy link
Member

Updating to hacl-star/hacl-star#940.
This needs to update to main once that PR is merged.

@coveralls
Copy link

coveralls commented Apr 25, 2024

Pull Request Test Coverage Report for Build 9564781291

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1867 of 10088 (18.51%) changed or added relevant lines in 12 files are covered.
  • 24 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-5.9%) to 48.135%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/EverCrypt_DRBG.c 2 8 25.0%
src/Hacl_Frodo1344.c 0 34 0.0%
src/Hacl_Frodo64.c 0 34 0.0%
src/Hacl_Frodo640.c 0 34 0.0%
src/Hacl_Frodo976.c 0 34 0.0%
src/EverCrypt_Hash.c 0 36 0.0%
src/Hacl_Hash_Blake2s.c 290 420 69.05%
src/Hacl_Hash_Blake2b.c 289 422 68.48%
src/Hacl_Hash_Blake2b_Simd256.c 275 416 66.11%
src/Hacl_Hash_Blake2s_Simd128.c 91 407 22.36%
Files with Coverage Reduction New Missed Lines %
src/Hacl_Hash_Blake2s.c 1 86.6%
src/Hacl_Hash_Blake2b.c 1 86.09%
src/Hacl_Hash_Blake2b_Simd256.c 1 65.98%
src/Lib_RandomBuffer_System.c 2 64.29%
src/Hacl_Hash_Blake2s_Simd128.c 9 32.55%
src/Hacl_Hash_SHA3.c 10 51.18%
Totals Coverage Status
Change from base Build 9564734956: -5.9%
Covered Lines: 29403
Relevant Lines: 61085

💛 - Coveralls

Copy link

cla-bot bot commented Jun 12, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

@cla-bot cla-bot bot removed the cla-signed label Jun 12, 2024
Copy link

cla-bot bot commented Jun 14, 2024

We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added.

@franziskuskiefer franziskuskiefer marked this pull request as ready for review June 18, 2024 12:14
@franziskuskiefer franziskuskiefer requested a review from a team as a code owner June 18, 2024 12:14
@franziskuskiefer franziskuskiefer merged commit 584c542 into main Jun 18, 2024
38 of 40 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/update-hacl-star branch June 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants