bench against libb2 #458
bench against libb2 #458
Conversation
Pull Request Test Coverage Report for Build 9588066057Details
💛 - Coveralls |
There may be a symbol clash with all the There's no flag to add debug symbols for benchmarks right now. You could add one. Otherwise, just throw in a |
|
Ok I've just gotten segfaults on my machine, but indeed, might be symbol clashes... if the code is the same between libb2 and blake2-ref (with the exception that the former does runtime cpu detection), then it might be easier to just benchmark blake2-ref with #defines for working around the symbol conflicts (or a good old sed). |
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
| @@ -288,28 +344,6 @@ HACL_blake2b_32_streaming(benchmark::State& state) | |||
|
|
|||
| BENCHMARK(HACL_blake2b_32_streaming)->Setup(DoSetup); | |||
|
|
|||
| static void | |||
There was a problem hiding this comment.
Is there a reason to drop these two?
@karthikbhargavan looks like you did this change.
As part of python/cpython#99108 I would like to gather some data as to the relative performance of HACL*'s blake2 implementation against libb2.
To that effect, I added cmake voodoo, and a few benchmarks.
Sadly, I'm getting a segfault, and I can't debug because I don't know how to build the benchmarks with debugging info.
@franziskuskiefer can you take a look at tell me i) whether you see any issue and/or ii) how to build benchmarks in debug mode so that I can at least try to figure out what's going on?
thanks!