Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable building docs for old ocaml tags #424

Merged
merged 1 commit into from
Aug 10, 2023
Merged

disable building docs for old ocaml tags #424

merged 1 commit into from
Aug 10, 2023

Conversation

franziskuskiefer
Copy link
Member

See #423

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner August 7, 2023 09:25
@cla-bot cla-bot bot added the cla-signed label Aug 7, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5783386920

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.764%
Totals Coverage Status
Change from base Build 5655047436: 0.0%
Covered Lines: 28938
Relevant Lines: 54844
💛 - Coveralls

@franziskuskiefer
Copy link
Member Author

@victor-dumitrescu for your FYI and an r+
The change in #421 makes such that all the old tags don't work anymore. But this forces us to fix it properly. But for now we could just disable it.

@franziskuskiefer franziskuskiefer self-assigned this Aug 7, 2023
@franziskuskiefer
Copy link
Member Author

Merging this now to fixup the CI.

@franziskuskiefer franziskuskiefer merged commit a4e9a1b into main Aug 10, 2023
75 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/disable-old-ocaml-tag-gh-pages branch August 10, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-dumitrescu victor-dumitrescu Awaiting requested review from victor-dumitrescu

Assignees

@franziskuskiefer franziskuskiefer

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@franziskuskiefer @coveralls