Changing sha2 benchmarks to refer to the faster Hacl_SHA2_Streaming versions #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikbhargavan
changed the title
Pull Request Test Coverage Report for Build 4252472757
💛 - Coveralls |
franziskuskiefer
requested changes
Feb 20, 2023
|
|
||
| template<class... Args> | ||
| void | ||
| HACL_Sha2_new_oneshot(benchmark::State& state, Args&&... args) |
There was a problem hiding this comment.
Looks like this function isn't used?
Please remove or use.
| @@ -159,7 +174,7 @@ BENCHMARK_CAPTURE(HACL_Sha2_oneshot, | |||
| sha2_224, | |||
| HACL_HASH_SHA2_224_DIGEST_LENGTH, | |||
| expected_digest_sha2_224, | |||
| Hacl_Hash_SHA2_hash_224) | |||
| Hacl_Streaming_SHA2_sha224) | |||
There was a problem hiding this comment.
This makes the benchmark pretend like the oneshot function exposed by the library have this performance. Which they don't
I agree that this should be used but a few things need to happen as well
- remove the slow API
- update the documentation to point consumers to the right API
I'm fine with doing this in follow-ups. But it either needs to be filed as follow-ups to tackle after this (maybe @duesee or @pnmadelaine can take care of this), or done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.