Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to HACL* 5c045cac1c48d555592ebbc86d55f1ec396adfbc #356

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

franziskuskiefer
Copy link
Member

Update to new HACL*, adding HKDF SHA384.

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner February 8, 2023 09:12
@cla-bot cla-bot bot added the cla-signed label Feb 8, 2023
@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 4132048118

  • 0 of 42 (0.0%) changed or added relevant lines in 1 file are covered.
  • 322 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 53.044%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Hacl_HKDF.c 0 42 0.0%
Files with Coverage Reduction New Missed Lines %
src/Hacl_Hash_Base.c 1 14.13%
src/EverCrypt_Curve25519.c 11 67.65%
src/EverCrypt_AutoConfig2.c 17 82.1%
src/Hacl_Curve25519_64.c 293 0%
Totals Coverage Status
Change from base Build 4114412109: -0.6%
Covered Lines: 30231
Relevant Lines: 56992

💛 - Coveralls

Copy link
Contributor

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you also update docs/reference/hacl/kdf/index.md to reflect the addition of HKDF SHA-2 384? It should be enough to add another bullet point at the top and doxygenfunction-reference it in the body.

@duesee
Copy link
Contributor

duesee commented Feb 9, 2023

Thanks for making the changes. I opened #357 and #358 to track the addition of benchmarks and tests for HKDF-SHA2-384. But let's get this in first 👍

@franziskuskiefer franziskuskiefer merged commit f054d80 into main Feb 9, 2023
@franziskuskiefer franziskuskiefer deleted the franziskus/update-hacl branch February 9, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants