benchmarks: Make benchmarks more robust and cleanup. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3995628912
💛 - Coveralls |
duesee
force-pushed
the
duesee/issue_37_8
branch
from
5b770c6
to
691d9ad
Compare
franziskuskiefer
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through (most) benchmarks and tried to spot anomalies, inconsistencies, bugs, etc. Also, due to the improved order I spotted a few missing benchmarks and will make another PR for them shortly. While at it I added (and resolved) some points described in #337.
The
cleanupcommits try to not make any fundamental changes to the benchmarks. However, they already resolve a few missing CPU initailizations and wrong function calls due to copy&paste errors. I will proceed with the remaining bullet points in #337.Sorry for this somehow messy PR. I wanted to finish this and did some changes that make this harder to review. If you have difficulties reviewing this, I can try to improve the presentation of this PR.