Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api.md - fix waitFor example #21

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

eran-cohen
Copy link
Contributor

@eran-cohen eran-cohen commented Sep 5, 2022

give a working example for using exitCode with waitFor, the current example doesn't work and creates a build error

What:

Why:

How:

Checklist:

  • Tests
  • TypeScript definitions updated
  • Ready to be merged

give a working example for using exitCode with waitFor, the current example doesn't work and creates a build error
@eran-cohen eran-cohen changed the title Update api.md Update api.md - fix waitFor example Sep 5, 2022
@crutchcorn
Copy link
Owner

Great change, thank you!

@crutchcorn crutchcorn merged commit 772b9d2 into crutchcorn:main Sep 5, 2022
@crutchcorn
Copy link
Owner

@all-contributors please add @eran-cohen for docs

@allcontributors
Copy link
Contributor

@crutchcorn

I've put up a pull request to add @eran-cohen! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants