Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import "links" element from Fahrplan, join multiple values with whitespace #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-tze
Copy link
Collaborator

@a-tze a-tze commented Feb 14, 2019

This information is useful in the releasing process, where the links can be rendered into the description for example.

@a-tze a-tze requested a review from jjeising February 14, 2019 19:07
@jjeising
Copy link
Member

Are we sure links are always properly escaped? I don't have a good feeling about space separation – this is already kind of a hack with multiple persons.

@a-tze
Copy link
Collaborator Author

a-tze commented Feb 15, 2019

I'm unsure about XSD of schedule.xml format, wether it defines some constraint on the content of that field or not.
As long as the tracker has no concept of multivalue properties, there is no other way than using a defined separation character. At the end, this might only produce broken links in the worst case.

@pegro
Copy link
Member

pegro commented Feb 15, 2019

What about storing some actual (and sanely parsed/handled) HTML/XML?
Like a property value of <a href="URL1">Link name1</a><a href="URL2">Link name2</a>...
I know it's still a hack, multivalue properties would solve that, but this is a variation of the "separation character" approach and might be usable elsewhere.

And if you don't like HTML, what about Markup? [[URL1|Link name1]][[URL2|Link name2]]
At least something with already defined rules, how to store/interpret.

@jjeising
Copy link
Member

What about storing some actual (and sanely parsed/handled) HTML/XML?

HTML sounds like the most reasonable approach yet. I would refrain from introducing another markup that has then to be parsed by API consumers.

What are our chances to implement multi-value properties?

@pegro
Copy link
Member

pegro commented Mar 25, 2019

I'd only start thinking about adding the level of complexity required for multi-value properties, if we have enough use-cases. Having multiple persons or links attached to a ticket, which both won't really parsed by neither tracker nor crs scripts, is a valid use-case, but not a strong one.

If we don't find more, we can think about allowing a simple array syntax or said HTML as property value.

@a-tze
Copy link
Collaborator Author

a-tze commented Mar 25, 2019

A simple array syntax, maybe like space separated values that must not contain spaces per definition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants