Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Android] Do not require certificate transparency #3962

Closed
wants to merge 1 commit into from

Conversation

sunlin-link
Copy link
Contributor

Certificate transparency is a unique feature of Chrome but non-standard
SSL protocol. It aims to improve the security aloneside with CA. But
Crosswalk is based on content shell so the network connections initiated
by it do not support this certificate policy. This causes a SSL error
called ERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED and makes the app
continue to pop up the "SSL Certificate Error Alert" dialog.

This patch declares that Crosswalk doesn't require certificate
transparency to bypass the SSL error above.

BUG=XWALK-7398

Certificate transparency is a unique feature of Chrome but non-standard
SSL protocol. It aims to improve the security aloneside with CA. But
Crosswalk is based on content shell so the network connections initiated
by it do not support this certificate policy. This causes a SSL error
called ERT_STATUS_CERTIFICATE_TRANSPARENCY_REQUIRED and makes the app
continue to pop up the "SSL Certificate Error Alert" dialog.

This patch declares that Crosswalk doesn't require certificate
transparency to bypass the SSL error above.

BUG=XWALK-7398
@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 5, 2016

Testing patch series with lincsoon/crosswalk@fd5f1bc678d9fe8131616fed2497cfb38da8fa23 as its head.

Bot Status
Crosswalk Android-X86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/4881)
Crosswalk Android x86-64 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android x86-64/builds/1931)
Crosswalk Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/4871)

@sunlin-link
Copy link
Contributor Author

@fujunwei @xzhan96 Please help to review

@fujunwei
Copy link
Contributor

fujunwei commented Dec 6, 2016

Did chromium upstream fixed this issue?
https://codereview.chromium.org/2495583002

@xzhan96
Copy link
Contributor

xzhan96 commented Dec 6, 2016

lgtm

@sunlin-link
Copy link
Contributor Author

@fujunwei No, the error code in Crosswalk is not same as this issue.

@fujunwei
Copy link
Contributor

fujunwei commented Dec 6, 2016

LGTM

@rakuco
Copy link
Member

rakuco commented Dec 6, 2016

I'd like a more detailed explanation of how Crosswalk and content shell differ from Chromium in this respect. I tried taking a look at this today and couldn't see what sort of "policies" Chromium implements that we do not.

https://m.baidu.com, which was the original URL causing trouble, has a certificate from Symantec, the CA that started the whole CT work upstream. The public key hashes that net::TransportSecurityState::ShouldRequireCT() iterates over are different when using Crosswalk/content shell and Chromium (even on Linux), but it is not clear to me why.

In other words: without a bigger explanation, this patch seems to be disabling legitimate checks and fixing the JIRA issue as a side-effect.

@rakuco
Copy link
Member

rakuco commented Dec 8, 2016

I'd like a more detailed explanation of how Crosswalk and content shell differ from Chromium in this respect. I tried taking a look at this today and couldn't see what sort of "policies" Chromium implements that we do not.

I've also posted this question upstream: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/_ZILH704AVU/ZD0XqL3JCgAJ

@rakuco
Copy link
Member

rakuco commented Dec 9, 2016

... and trying to get additional clarification here: https://bugs.chromium.org/p/chromium/issues/detail?id=669978#c9

@rakuco
Copy link
Member

rakuco commented Dec 15, 2016

Superseded by #3964.

@rakuco rakuco closed this Dec 15, 2016
@sunlin-link sunlin-link deleted the develop branch January 20, 2017 05:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants