Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Fix some android rebasing issues #3957

Merged
merged 6 commits into from
Nov 16, 2016
Merged

Fix some android rebasing issues #3957

merged 6 commits into from
Nov 16, 2016

Conversation

msisov
Copy link

@msisov msisov commented Nov 14, 2016

please take a look

@rakuco
Copy link
Member

rakuco commented Nov 14, 2016

In general we tend to use full declarations instead of using clauses; would your patch be much bigger if you did that instead?

@msisov
Copy link
Author

msisov commented Nov 16, 2016

Got it!

Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks a lot!

@rakuco rakuco merged commit ba55e8d into crosswalk-project:next Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants