This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Tizen] Enable/Disable the shared process mode at runtime. #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with joone/crosswalk@3443c3e as its head.
|
| @@ -81,6 +81,9 @@ class XWalkRunner { | |||
| void EnableRemoteDebugging(int port); | |||
| void DisableRemoteDebugging(); | |||
|
|
|||
| bool SharedProcessModeEnabled() { return shared_process_mode_enabled_; } | |||
| void DisableSharedProcessMode() { shared_process_mode_enabled_ = false; } | |||
There was a problem hiding this comment.
no! you cannot just disable/enable it at an arbitrary moment. Please remove the method above.
3443c3e
to
8867273
Compare
|
Testing patch series with joone/crosswalk@8867273 as its head.
|
8867273
to
865bc80
Compare
|
Testing patch series with joone/crosswalk@865bc80 as its head.
|
865bc80
to
dd84801
Compare
|
Testing patch series with joone/crosswalk@dd84801 as its head.
|
| XWalkRunnerTizen::XWalkRunnerTizen() { | ||
| CommandLine* cmd_line = CommandLine::ForCurrentProcess(); | ||
| if (cmd_line->HasSwitch(switches::kXWalkDisableSharedProcessMode)) | ||
| shared_process_mode_enabled_ = false; |
There was a problem hiding this comment.
shared_process_mode_enabled_ = !(cmd_line->HasSwitch(switches::kXWalkDisableSharedProcessMode));
|
lgtm with comments |
dd84801
to
4283223
Compare
|
Testing patch series with joone/crosswalk@4283223 as its head.
|
4283223
to
0093e54
Compare
|
Testing patch series with joone/crosswalk@0093e54 as its head.
|
0093e54
to
18d4afe
Compare
|
Testing patch series with joone/crosswalk@18d4afe as its head.
|
18d4afe
to
93adb7a
Compare
|
Testing patch series with joone/crosswalk@93adb7a as its head.
|
93adb7a
to
9eec48b
Compare
|
Testing patch series with joone/crosswalk@9eec48b as its head.
|
The shared process mode has been enabled by default, which makes debugging very hard so we need to enable/disable it at runtime. This patch allows to add a new command line option (--disable-shared-process-mode) for disabling the shared process mode at runtime. Bug=XWALK-2987
9eec48b
to
6ede6d1
Compare
|
Testing patch series with joone/crosswalk@6ede6d1 as its head.
|
|
@pozdnyakov Can you merge this patch? |
pozdnyakov
pushed a commit
that referenced
this pull request
Dec 9, 2014
[Tizen] Enable/Disable the shared process mode at runtime.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared process mode has been enabled by default, which makes
debugging very hard so we need to enable/disable it at runtime.
This patch allows to add a new command line option
(--disable-shared-process-mode) for disabling the shared process
mode at runtime.
Bug=XWALK-2987