refac(chart): Split out webhook and metrics endpoints into dedicated services #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjbravi Please follow the instructions in the PR checklist and fill it out. |
|
Hi @negz! Do you mind adding the backport label for me? I think I don't have the rights to do so once the PR is already opened. |
|
@gjbravi I don't think we should back port this, as its not a bug fix. It's okay to strikethrough that one. |
|
Hi @negz, could you please re-check it? Please let me know in case this PR requires a doc, I would be happy writing one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The main goal of this change is to better separate and organize, between two services, different target ports from crossplane pods; being webhooks(9443) and metrics(8080).
This change facilitates targeted monitoring of Crossplane metrics via Prometheus ServiceMonitor and improves the overall organization by having a suggestive service name.
Fixes #
N/A
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Addedbackport release-x.ylabels to auto-backport this PR.