Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes permission issues with userns on Docker host #96

Merged
merged 1 commit into from
May 17, 2017

Conversation

lawliet89
Copy link
Contributor

Fixes #90

Please let me know if this approach is not satisfactory.

  • I added two new dependencies
  • I am not sure how we can test this

@japaric
Copy link
Contributor

japaric commented May 15, 2017

@lawliet89 Sorry for the delay!

This looks good to me.

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit 47c562e has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit 47c562e with merge 47c562e...

@homunkulus
Copy link
Contributor

💔 Test failed - status-travis

@lawliet89
Copy link
Contributor Author

Not sure what failed on powerpc. Seem to be the same issue for the other PRs too.

@japaric
Copy link
Contributor

japaric commented May 17, 2017

That should be fixed now.

@homunkulus r+

@homunkulus
Copy link
Contributor

‼️ Invalid head SHA found, retrying: 0000000000000000000000000000000000000000

@homunkulus
Copy link
Contributor

📌 Commit 47c562e has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit 47c562e with merge 1ecf0e4...

japaric pushed a commit that referenced this pull request May 17, 2017
Fixes permission issues with userns on Docker host

Fixes #90

Please let me know if this approach is not satisfactory.
 - I added two new dependencies
 - I am not sure how we can test this
@homunkulus
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: japaric
Pushing 1ecf0e4 to master...

@homunkulus homunkulus merged commit 47c562e into cross-rs:master May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants