Allow environment variables to contain numbers #1481
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
approved these changes
Apr 30, 2024
Emilgardis
added
no-ci-targets
|
Awesome, good catch. Feel free to add a changelog entry via |
pizaCat
force-pushed
the
allow-numbers-in-env-vars
branch
from
93f6bd1
to
20c73df
Compare
|
I added the .changes entry, hopefully the filename is ok. It looked like the PR # was used for filename so I did that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When environment variable pass-through is used, a warning is displayed if the name of the variable contains a number and the value is taken from the host. For example:
The variable is still passed onto the cross container with the value from the host, but the warning is misleading.