-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile compiler-builtins test suite with the "mangled-names" feature enabled #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled otherwise we run into linking errors (due to multiple codegen units?)
@homunkulus r+ |
📌 Commit f2806be has been approved by |
japaric
pushed a commit
that referenced
this pull request
Oct 8, 2017
compile compiler-builtins test suite with the "mangled-names" feature enabled otherwise we run into linking errors (due to multiple codegen units?)
This was referenced Oct 8, 2017
Merged
💔 Test failed - status-travis |
to avoid linking problems when using several codegen units
@homunkulus r+ |
📌 Commit fb93d9e has been approved by |
japaric
pushed a commit
that referenced
this pull request
Oct 8, 2017
compile compiler-builtins test suite with the "mangled-names" feature enabled otherwise we run into linking errors (due to multiple codegen units?)
☀️ Test successful - status-travis |
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Update the ci matrix to be target centric. Specify for each target the os on which the build steps shall run. Install `cross` if needed for a target. Not that `cross` requires a custom rev instead of the latest relaese for linking target for `aarch64-linux-android`. This should change with the next release of `cross`: cross-rs/cross#135). * Add target `aarch64-linux-android`. * Add target `aarch64-linux-unknown-gnu`. * Use cargo actions https://github.com/actions-rs/cargo. * Add cargo caching https://github.com/Swatinem/rust-cache. * Add sccache https://github.com/Mozilla-Actions/sccache-action
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Update the ci matrix to be target centric. Specify for each target the os on which the build steps shall run. Install `cross` if needed for a target. Not that `cross` requires a custom rev instead of the latest relaese for linking target for `aarch64-linux-android`. This should change with the next release of `cross`: cross-rs/cross#135). * Add target `aarch64-linux-android`. * Use cargo actions https://github.com/actions-rs/cargo. * Add cargo caching https://github.com/Swatinem/rust-cache. * Add sccache https://github.com/Mozilla-Actions/sccache-action
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Update the ci matrix to be target centric. Specify for each target the os on which the build steps shall run. Install `cross` if needed for a target. Not that `cross` requires a custom rev instead of the latest relaese for linking target for `aarch64-linux-android`. This should change with the next release of `cross`: cross-rs/cross#135). * Add target `aarch64-linux-android`. * Use cargo actions https://github.com/actions-rs/cargo. * Add cargo caching https://github.com/Swatinem/rust-cache. * Add sccache https://github.com/Mozilla-Actions/sccache-action
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Update the ci matrix to be target centric. Specify for each target the os on which the build steps shall run. Install `cross` if needed for a target. Not that `cross` requires a custom rev instead of the latest relaese for linking target for `aarch64-linux-android`. This should change with the next release of `cross`: cross-rs/cross#135). * Add target `aarch64-linux-android`. * Use cargo actions https://github.com/actions-rs/cargo. * Add cargo caching https://github.com/Swatinem/rust-cache. * Add sccache https://github.com/Mozilla-Actions/sccache-action
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Update the ci matrix to be target centric. Specify for each target the os on which the build steps shall run. Install `cross` if needed for a target. Not that `cross` requires a custom rev instead of the latest relaese for linking target for `aarch64-linux-android`. This should change with the next release of `cross`: cross-rs/cross#135). Add targets `aarch64-linux-android`, `aarch64-unknown-linux-gnu` and `x86_64-unknown-linux-musl`,
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Update the ci matrix to be target centric. Specify for each target the os on which the build steps shall run. Install `cross` if needed for a target. `cross` requires a custom rev instead of the latest relaese for linking target for `aarch64-linux-android`. This should change with the next release of `cross`: cross-rs/cross#135). Add targets `aarch64-linux-android`, `aarch64-unknown-linux-gnu` and `x86_64-unknown-linux-musl`,
flxo
pushed a commit
to flxo/samply
that referenced
this pull request
Nov 14, 2023
Revise the CI matrix to adopt a target-centric approach. Clearly define the operating system for each target, outlining the specific OS on which the build steps are intended to execute. Ensure the installation of cross where necessary for individual targets. Note that for the aarch64-linux-android target, a custom revision is currently required instead of relying on the latest release for proper linking. It is anticipated that this requirement will be addressed in the upcoming release of cross (refer to: cross-rs/cross#135). Add targets `aarch64-linux-android`, `aarch64-unknown-linux-gnu` and `x86_64-unknown-linux-musl`,
mstange
pushed a commit
to mstange/samply
that referenced
this pull request
Nov 15, 2023
Revise the CI matrix to adopt a target-centric approach. Clearly define the operating system for each target, outlining the specific OS on which the build steps are intended to execute. Ensure the installation of cross where necessary for individual targets. Note that for the aarch64-linux-android target, a custom revision is currently required instead of relying on the latest release for proper linking. It is anticipated that this requirement will be addressed in the upcoming release of cross (refer to: cross-rs/cross#135). Add targets `aarch64-linux-android`, `aarch64-unknown-linux-gnu` and `x86_64-unknown-linux-musl`,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise we run into linking errors (due to multiple codegen units?)