Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emscripten permission issue #125

Merged
merged 4 commits into from
Sep 22, 2017

Conversation

malbarbo
Copy link
Contributor

Fixes #110

@japaric
Copy link
Contributor

japaric commented Sep 21, 2017

Thanks for the PR, @malbarbo. LGTM.

I allowed failures in the wasm and asmjs builds in #105 which is about to land. Please undo that part in this PR then you can r+ this yourself.

@homunkulus delegate+

@homunkulus
Copy link
Contributor

✌️ @malbarbo can now approve this pull request

@malbarbo
Copy link
Contributor Author

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit f0ed74c has been approved by malbarbo

@homunkulus
Copy link
Contributor

⌛ Testing commit f0ed74c with merge f0ed74c...

@homunkulus
Copy link
Contributor

💔 Test failed - status-travis

@malbarbo
Copy link
Contributor Author

@japaric Is the mips failure spurious?

@japaric
Copy link
Contributor

japaric commented Sep 21, 2017

Yes, I think so. I have restarted that build job.

@japaric
Copy link
Contributor

japaric commented Sep 21, 2017

:-( too late. The other PR is being tested so the build can't be resumed (the auto branch tip changed).

@homunkulus retry

@japaric
Copy link
Contributor

japaric commented Sep 22, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit 7daa8f0 has been approved by japaric

@japaric
Copy link
Contributor

japaric commented Sep 22, 2017

@homunkulus r+

@homunkulus
Copy link
Contributor

📌 Commit fba15a8 has been approved by japaric

@homunkulus
Copy link
Contributor

⌛ Testing commit fba15a8 with merge 3fdf267...

japaric pushed a commit that referenced this pull request Sep 22, 2017
Fix emscripten permission issue

Fixes #110
@homunkulus
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: japaric
Pushing 3fdf267 to master...

@homunkulus homunkulus merged commit fba15a8 into cross-rs:master Sep 22, 2017
@jan-hudec
Copy link

jan-hudec commented Sep 22, 2017

@japaric, did the build push out the Docker image? I've tried again, but I am still getting the same error: https://travis-ci.org/rust-locale/locale_config/jobs/278730580 (I've restarted the build, it passed the second time around)

@japaric
Copy link
Contributor

japaric commented Sep 22, 2017

@jan-hudec you won't get these changes until I release a new Cross version. I'll do so later today.

@jan-hudec
Copy link

@japaric, thanks, I'll try later then.

@japaric
Copy link
Contributor

japaric commented Sep 22, 2017

@jan-hudec it should work now

@jan-hudec
Copy link

@japaric, yes, looks good now. Thanks.

@malbarbo malbarbo deleted the emscripten-fix-perm branch October 20, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants