Expand MAILTO and MAILFROM environment variables #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes cronie-crond#26 Signed-off-by: Fernando Cappi <[email protected]>
Signed-off-by: Fernando Cappi <[email protected]>
t8m
requested changes
Jul 14, 2020
There was a problem hiding this comment.
I am not too fond of using wordexp to perform the substitution. If there was a way how to limit the expansion to environment variable expansion then I'd be OK, however that is not the case. There is also wildcard expansion, etc. Also I am not sure if wordexp is available on all platforms that cronie is used on.
Signed-off-by: Fernando Cappi <[email protected]>
|
Agreed that wordexp is doing more than what we need and we may have some unexpected behaviors using it. So I created a function to find env vars in a string and another one to expand them, so we don't have the dependency on wordexp anymore. Could you please take a look? Thank you for the review! |
t8m
requested changes
Jul 21, 2020
Signed-off-by: Fernando Cappi <[email protected]>
t8m
requested changes
Jul 23, 2020
Signed-off-by: Fernando Cappi <[email protected]>
|
Merged, thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request was only for MAILFROM but I think it makes sense for MAILTO as well. Let me know if you do not agree with this, so I can remove this part.
Closes #26
Signed-off-by: Fernando Cappi [email protected]