Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - GMaps API key as configuration #8

Closed
warmfusion opened this issue Apr 3, 2017 · 3 comments
Closed

Feature Request - GMaps API key as configuration #8

warmfusion opened this issue Apr 3, 2017 · 3 comments
Assignees

Comments

@warmfusion
Copy link

Rather than having to hand-wrangle the index.html each time I export the map, can I provide the API key as part of the Advanced Configuration (and for it to persist) such that when the index is written out the key is automatically included?

@dbartholomae
Copy link

As far as my experiments go, you just need to copy the image directory and keep the old index.html :)

@credomane credomane self-assigned this Apr 19, 2017
@credomane
Copy link
Owner

Adding this feature through the new mod settings GUI as a per-user setting. That should allow you to set your key once and use is in every game! I'm liking these new mod settings in 0.15.

credomane pushed a commit that referenced this issue May 2, 2017
@credomane
Copy link
Owner

credomane commented May 2, 2017

Noticed a bug with the new mod setting GUI. Please change the mod setting from the main menu only with NO game loaded. If you change the setting while a save is loaded then setting it isn't saved at all. I'm making a test mod show-casing the issue and will file a big report with Factorio devs in a little while.

Leaving this open until I hear back from the devs on a resolution.

[edit]
I made a goof and pulled the mod setting incorrectly. The in-game mod setting menu still shows the wrong config value but the settings actually are changed. This is a Factorio bug hopefully the devs will get it fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants