Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Request deduplication #8

Merged
merged 9 commits into from
May 20, 2024
Merged

feat: Request deduplication #8

merged 9 commits into from
May 20, 2024

Conversation

creativecreature
Copy link
Owner

Overview

This PR adds request deduplication by making the cache track in-flight requests for keys. This works for batchable endpoints too, as the cache is able to cherry-pick the keys it needs from different outgoing batches.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.05797% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 89.43%. Comparing base (486dad1) to head (c384ac6).

Files Patch % Lines
passthrough.go 46.42% 9 Missing and 6 partials ⚠️
inflight.go 93.26% 4 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   90.29%   89.43%   -0.87%     
==========================================
  Files          10       11       +1     
  Lines         567      672     +105     
==========================================
+ Hits          512      601      +89     
- Misses         35       45      +10     
- Partials       20       26       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creativecreature creativecreature merged commit b91f309 into main May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants