Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1 - add new pure CQL library RxSig for parsing free text SIGs, translated from a Java version #2

Merged
merged 5 commits into from
Sep 12, 2018

Conversation

duncand
Copy link
Contributor

@duncand duncand commented Mar 16, 2018

The initial commit, from 2018 Feb 28, just includes the new CQL library itself under pages/cql; related files under pages/elm and such will follow.

@duncand
Copy link
Contributor Author

duncand commented Mar 16, 2018

This pull request is now fundamentally complete as far as providing a CQL library that encodes SIG parsing, specifically a translation of the RxSig Java library by U of U, and is available in the IG with some documentation.

The library resource has a few spots marked TODO and otherwise needs the review of a more savvy person so that the right metadata is in there. The file was created by taking an existing library resource in the same folder and chopping or modifying parts as appropriate, but I didn't yet know how to finish it up.

If further documentation is required, such as examples of use, please indicate where it should go and what form it should take, with an example.

Note that this version of the RxSig.cql, while changing some things from the Java version to be more idiomatic for CQL, notably still just provides 1:1 correspondence with the parsed outputs of the Java version, such as separate result tuple values for "high" and "low" doses; a further enhancement that can and should be made is adding more result attributes that combines existing result attributes into more complex types like Interval or Quantity to make it more idiomatic for CQL.

@duncand
Copy link
Contributor Author

duncand commented Aug 14, 2018

Whomever has the privileges, please evaluate this merge request and accept the new library. This request has been waiting for 5 months now. Thank you.

@brynrhodes brynrhodes self-requested a review September 12, 2018 02:40
@brynrhodes brynrhodes merged commit 6d20f13 into cqframework:master Sep 12, 2018
@duncand
Copy link
Contributor Author

duncand commented Sep 12, 2018

Thank you for merging this pull request. Feel free to tag me if someone wants further enhancements to the RxSig library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants