Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cql 1.2 alignment 2 #21

Closed
wants to merge 2 commits into from
Closed

Cql 1.2 alignment 2 #21

wants to merge 2 commits into from

Conversation

lukoktonos
Copy link
Contributor

@lukoktonos lukoktonos commented May 8, 2018 •
edited
Loading

This PR adds some fixes for section 9.3 and 9.5 of the CQL spec (1 commit for each, see their extended commit messages for squashed commit messages).

Related JIRA Links:

CDS Connect and Bonnie are the main users of this repository.
It is strongly recommended to include a person from each of those projects as a reviewer.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • Code coverage has not gone down and all code touched or added is covered.
Branch Coverage
bonnie 81.23% Statements 4514/5557
74.19% Branches 920/1240
25.47% Functions 764/3000
80.77% Lines 4334/5366
cql_1.2_alignment_2 81.62% Statements 4593/5627
74.82% Branches 939/1255
25.72% Functions 774/3009
81.17% Lines 4410/5433

Reviewer:

Name: @cmoesel

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

Name: @jbradl11

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

mayerm94 and others added 2 commits April 27, 2018 09:44
@mayerm94 @jbradl11
Throw IncompatibleTypes exception in Equal Greater Greater Or Equal L… (
ac90c42 
#16)

* Throw IncompatibleTypes exception in Equal Greater Greater Or Equal Less Less Or Equal and Not Equal when comaring incompatible types.
@jbradl11
Align to cql1.2 section 9.3 (#20)
aa3f368 
* Fix DateTime parse and toString

- parse should support offset using `Z` (equivalent to `+00:00`)
- toString had two bugs: `ms` was only 2 digits (should be 3) and the offset was missing `:` between hours and minutes

* refactor DateTime.parse to align ToDateTime to CQL spec

From the CQL Spec:
ToDateTime - "If input string is not formatted correctly or does
not represent a valid date/time value, a run-time error is thrown"

Previously a null was returned instead of an exception being thrown

* update ToDecimal and ToInteger to align with CQL 1.2 spec

* update ToQuantity to align with CQL 1.2 spec

* add passing unit tests for ToTime

* fixes for DateTime parse tests

* update datetime parsing for Z timezoneoffset

* add comment explaining moment strict parameter
@lukoktonos lukoktonos mentioned this pull request May 8, 2018
Closed
23 tasks
@lukoktonos
Copy link
Contributor Author

Closing because we decided this should be off of master instead. Will open new PR with master version.

@lukoktonos lukoktonos closed this May 9, 2018
@cmoesel cmoesel deleted the cql_1.2_alignment_2 branch January 4, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbradl11 jbradl11 Awaiting requested review from jbradl11

@cmoesel cmoesel Awaiting requested review from cmoesel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukoktonos @mayerm94