Add race and ethnicity bindings to bindings collection #531
Conversation
…443-race-ethnicity-to-spreadsheet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #531 +/- ##
============================================
- Coverage 21.91% 21.85% -0.06%
- Complexity 1672 1673 +1
============================================
Files 297 297
Lines 25317 25390 +73
Branches 3990 4005 +15
============================================
+ Hits 5548 5550 +2
- Misses 18848 18920 +72
+ Partials 921 920 -1 ☔ View full report in Codecov by Sentry. |
| @@ -121,10 +121,84 @@ private void getBindings(String sdName, List<ElementDefinition> eds, String sdUR | |||
| sdbo.setBindingValueSetVersion(valueSetVersion); | |||
| bindingObjects.put(sdName + "." + sdbo.getElementId(), sdbo); | |||
| } | |||
| else if(ed.getId().equalsIgnoreCase("patient.extension:race") | |||
There was a problem hiding this comment.
I may be missing some context, but is this really what we want here? Seems like we want to generalize this for all potential extensions with bindings, right? Something like ed.hasExtension() or type checking on the ElementDefinition.
| } | ||
| sdbo.setBindingValueSetVersion(valueSetVersion); | ||
| if (null != elementValueSet) { | ||
| StringBuilder codeSystemURLs = new StringBuilder();; |
| StringBuilder codeSystemURLs = new StringBuilder();; | ||
| Map<String, String> codeSystemsMap = new HashMap<>(); | ||
| getValueSetCodeSystems(elementValueSet, codeSystemsMap); | ||
| if(null != codeSystemsMap && !codeSystemsMap.isEmpty()) { |
There was a problem hiding this comment.
codeSystemsMap will never be null (see line 181)
| valueSetVersion = this.canonicalResourceDependenciesAtlas.getValueSets().getByCanonicalUrlWithVersion(sdbo.getBindingValueSetURL()).getVersion(); | ||
| sdbo.setBindingValueSetName(this.canonicalResourceDependenciesAtlas.getValueSets().getByCanonicalUrlWithVersion(sdbo.getBindingValueSetURL()).getName()); | ||
| elementValueSet = this.canonicalResourceDependenciesAtlas.getValueSets().getByCanonicalUrlWithVersion(sdbo.getBindingValueSetURL()); | ||
| } else if (valueSetVersion.length() < 1 && bindingValueSet.contains("|")) { |
There was a problem hiding this comment.
Is checking the valueSetVersion string length necessary here? Seems like it is set in the previous if statements. If it is necessary, use valueSetVersion.isEmpty().
| CanonicalType canonicalType = new CanonicalType(); | ||
| canonicalType.setValue(String.valueOf(ed.getType().get(0).getProfile().get(0))); | ||
| ed.getType().get(0).getProfile().get(0).getValueAsString(); | ||
| String urlValue = ed.getType().get(0).getProfile().get(0).toString(); |
There was a problem hiding this comment.
This is set, but never used
tooling/pom.xml
Outdated
| @@ -333,6 +333,12 @@ | |||
| <artifactId>mockserver-client-java</artifactId> | |||
| <version>5.14.0</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
I didn't notice where this dependency is being used in this PR.
There was a problem hiding this comment.
Looks good! Waiting on @brynrhodes to give the final go-ahead.
Issue #433 QI Core Value Set and Code System Query Issue
Description
visitExtensions was added to StructureDefinitionElementBindingVisitor to visit the extensions and collect the bindings especially for patient.extension:race and patient.extension:ethnicity.
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0