Cqf-Tooling : NewRefreshIg update #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2024 13:49
_Made sure that we have the cql data inside the json library and that it matches the udpated cql _Update tests to verify everything works as expected.
brynrhodes
reviewed
May 15, 2024
| import java.util.stream.Collectors; | ||
| import java.util.stream.Stream; | ||
|
|
||
| public class CqlRefresh extends Refresh { |
There was a problem hiding this comment.
Should call this CqlVersionRefresh, yes?
There was a problem hiding this comment.
I'll rename it thanks !
brynrhodes
reviewed
May 15, 2024
| public class CqlRefresh extends Refresh { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(CqlRefresh.class); | ||
| private final Pattern VERSION_PATTERN = Pattern.compile("^(library\\s+(\\S+)\\s+version\\s+)'[0-9]+\\.[0-9]+\\.[0-9]+'"); |
There was a problem hiding this comment.
Not sure whether this would be easier, but it seems like it would definitely be more robust to use the Antlr visitor framework for this?
brynrhodes
approved these changes
May 15, 2024
6d28250
to
fc3c1d8
Compare
JPercival
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Added CqlRefresh in order to update cql file before conversion.
_Made sure that we have the cql data inside the json library and that it matches the udpated cql
_Update tests to verify everything works as expected.
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0