#759: Added service loader pattern for serialization frameworks #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/DefaultModelInfoProvider.java
Show resolved
Hide resolved
Src/java/elm/src/main/java/org/cqframework/cql/elm/serializing/ElmLibraryWriter.java
Outdated
Show resolved
Hide resolved
...kson/src/main/java/org/cqframework/cql/elm/serializing/jackson/ElmLibraryReaderProvider.java
Show resolved
Hide resolved
|
I really like the idea of XML and JSON Elm Library readers/writers not even being a part of cql-to-elm. Maybe they shouldn't even be a thing in the long run, given the many problems we are having with export/import with both Jackson and JAXB. |
This was referenced Jun 28, 2022
vitorpamplona
approved these changes
Jul 1, 2022
|
This is good to go in my tests. |
JPercival
approved these changes
Jul 1, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ModelInfoReader and ElmLibraryReader/Writer interfaces in the cql-to-elm package and a service loader pattern to support using different serialization frameworks based on which packages are included.
model-jackson: ModelInfoReader implementations using Jackson
model-jaxb: ModelInfoReader implementations using JAXB
elm-jackson: ElmLibraryReader/Writer implementations using Jackson
elm-jaxb: ElmLibraryReader/Writer implementations using JAXB
In addition, this PR refactors the CLI into a new cql-to-elm-cli package that has the command-line translator only.