Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine-fhir tests improvements #1368

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

antvaset
Copy link
Contributor

Two small changes:

  • Enabling the FactorialOfFive test:
    Succeeds in checking ({ 1, 2, 3, 4, 5 }) Num aggregate Result starting 1: Result * Num = 120 with no changes needed.

  • Fixing the expression logic for the RolledOutIntervals test and adding the expected output, but keeping the test skipped:
    For future reference, if you enable the test, you get an execution error Invalid precision: 1. This is because duration in days of X is interpreted as an integer which, when converted to a quantity, has unit '1' and not 'day'.

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.27%. Comparing base (5d9ccd6) to head (be98a1d).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1368   +/-   ##
=========================================
  Coverage     62.27%   62.27%           
  Complexity     6952     6952           
=========================================
  Files           492      492           
  Lines         27727    27727           
  Branches       5506     5506           
=========================================
  Hits          17266    17266           
  Misses         8197     8197           
  Partials       2264     2264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival enabled auto-merge (squash) June 12, 2024 15:41
@JPercival JPercival disabled auto-merge June 12, 2024 16:14
@JPercival JPercival merged commit e00c396 into cqframework:master Jun 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants