Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to JUnit 5, apply JUnit best practices #1360

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

JPercival
Copy link
Contributor

  • Migrate all tests to Junit 5
  • Apply Junit 5 best practices where possible (such as omitting the public modifier)
  • Fix various errors, like parameter ordering

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.27%. Comparing base (c4ceada) to head (2995994).

Files Patch % Lines
...n/java/org/cqframework/fhir/utilities/IGUtils.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1360   +/-   ##
=========================================
  Coverage     62.26%   62.27%           
+ Complexity     6954     6952    -2     
=========================================
  Files           492      492           
  Lines         27732    27727    -5     
  Branches       5506     5506           
=========================================
- Hits          17268    17266    -2     
+ Misses         8201     8197    -4     
- Partials       2263     2264    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 69005d7 into master Apr 26, 2024
5 checks passed
@JPercival JPercival deleted the feature-junit-5 branch April 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants