Fix JUnit Tests #1359
Merged
Fix JUnit Tests #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uture, but for now needed to standardize
|
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1359 +/- ##
============================================
- Coverage 62.90% 62.26% -0.65%
- Complexity 6144 6953 +809
============================================
Files 479 492 +13
Lines 25501 27732 +2231
Branches 4723 5506 +783
============================================
+ Hits 16042 17267 +1225
- Misses 7295 8202 +907
- Partials 2164 2263 +99 ☔ View full report in Codecov by Sentry. |
barhodes
approved these changes
Apr 23, 2024
brynrhodes
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As some point in the future we'd like to migrate all tests to JUnit. In the meantime, most of the tests are written using TestNG. The CI Server was not executing JUnit-based tests, causing a few regressions.