Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for localIds and Nary function resolution #1356

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

JPercival
Copy link
Contributor

  • Added more tests to verify that compiled ELM does contain localIds.
  • Fixed cases where nodes created via reflection did not have Ids assigned.
  • Fixed cases where NaryFunctions where resolved as BinaryFunctions
  • Added assertions to the CQL compiler to validate all nodes have ids
  • Refactored/Removed cases where localIds could be null.

@JPercival JPercival enabled auto-merge (squash) April 22, 2024 17:09
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (ec84b9e) to head (4e5d22f).

Files Patch % Lines
.../preprocessor/CqlPreprocessorElmCommonVisitor.java 28.57% 4 Missing and 1 partial ⚠️
...qframework/cql/cql2elm/SystemFunctionResolver.java 91.42% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1356      +/-   ##
============================================
- Coverage     63.18%   63.18%   -0.01%     
+ Complexity     6128     6126       -2     
============================================
  Files           468      468              
  Lines         25336    25315      -21     
  Branches       4716     4713       -3     
============================================
- Hits          16009    15995      -14     
+ Misses         7170     7166       -4     
+ Partials       2157     2154       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 70722a1 into master Apr 23, 2024
5 checks passed
@JPercival JPercival deleted the bug-more-localId-fixes branch April 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants