Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run $expand on type instead of instance if url is preset #483

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

TahaAttari
Copy link
Collaborator

No description provided.

@TahaAttari TahaAttari requested a review from barhodes June 26, 2024 23:17
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 62.02%. Comparing base (16a4d5a) to head (ac08bfd).

Files Patch % Lines
...f/fhir/utility/client/TerminologyServerClient.java 62.50% 3 Missing and 9 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #483      +/-   ##
============================================
+ Coverage     62.00%   62.02%   +0.02%     
- Complexity     3552     3558       +6     
============================================
  Files           328      328              
  Lines         17574    17603      +29     
  Branches       2707     2715       +8     
============================================
+ Hits          10897    10919      +22     
  Misses         5472     5472              
- Partials       1205     1212       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@barhodes barhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem correct to me. The expansionParameters object being passed in here is a contained Parameters resource in the rootSpecificationLibrary. How would that singular Parameters object contain the url parameter for each ValueSet we are expanding?

@TahaAttari TahaAttari requested a review from barhodes June 27, 2024 15:40
@barhodes barhodes merged commit c8d5317 into master Jun 27, 2024
7 checks passed
@barhodes barhodes deleted the update-terminology-client-to-use-url-param branch June 27, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants