Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the SDC Observation Extract Category extension #475

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

barhodes
Copy link
Contributor

@barhodes barhodes commented Jun 8, 2024

When extracting using observation based extraction, if the item has an SDC Observation Extract Category extension, use the value of that extension for the category of the extracted Observation. If no extension is present the category will default to "survey".

Closes #474

Copy link

github-actions bot commented Jun 8, 2024

Formatting check succeeded!

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.06%. Comparing base (65c59bb) to head (2dde19b).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #475      +/-   ##
============================================
+ Coverage     62.04%   62.06%   +0.02%     
- Complexity     3561     3565       +4     
============================================
  Files           328      328              
  Lines         17609    17616       +7     
  Branches       2715     2718       +3     
============================================
+ Hits          10925    10934       +9     
+ Misses         5472     5470       -2     
  Partials       1212     1212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@barhodes barhodes added bug Something isn't working CDS All issues related to the CDS project labels Jun 8, 2024
Copy link
Contributor

@JPercival JPercival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the test coverage up to 80% on changed code?

@barhodes barhodes requested a review from JPercival June 13, 2024 21:00
@JPercival JPercival merged commit 84880fe into master Jul 3, 2024
6 checks passed
@JPercival JPercival deleted the support-observation-extract-category branch July 3, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CDS All issues related to the CDS project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDC Observation Extract Category extension is not supported by the $extract operation
2 participants