Aphl 969 refactor endpoint #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
============================================
+ Coverage 60.66% 60.87% +0.20%
- Complexity 3438 3461 +23
============================================
Files 329 328 -1
Lines 17544 17538 -6
Branches 2706 2703 -3
============================================
+ Hits 10643 10676 +33
+ Misses 5689 5656 -33
+ Partials 1212 1206 -6 ☔ View full report in Codecov by Sentry. |
Chris0296
force-pushed
the
aphl-969-refactor-endpoint
branch
from
69ababc
to
37b3ea9
Compare
TahaAttari
approved these changes
May 24, 2024
-Removed unneeded EndpointCredentials class, now using Extensions under Endpoint class
Chris0296
force-pushed
the
aphl-969-refactor-endpoint
branch
from
37b3ea9
to
3b6ae61
Compare
JPercival
approved these changes
May 24, 2024
JPercival
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit 59aecb6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed EndpointCredentials class as we will use Extensions of Endpoint class. Throw more specific errors where credentials are missing.