Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge $package operation from CQF-Ruler with ValueSet expansion capability #455

Merged
merged 5 commits into from
May 14, 2024
Merged

Merge $package operation from CQF-Ruler with ValueSet expansion capability #455

merged 5 commits into from
May 14, 2024

Conversation

Chris0296
Copy link
Collaborator

No description provided.

@Chris0296 Chris0296 marked this pull request as ready for review May 6, 2024 16:50
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.10574% with 231 lines in your changes are missing coverage. Please review.

Project coverage is 60.63%. Comparing base (aaa2636) to head (4948291).

Files Patch % Lines
...visitor/dstu3/KnowledgeArtifactPackageVisitor.java 69.34% 35 Missing and 26 partials ⚠️
...ty/visitor/r5/KnowledgeArtifactPackageVisitor.java 69.19% 35 Missing and 26 partials ⚠️
...ty/visitor/r4/KnowledgeArtifactPackageVisitor.java 70.61% 31 Missing and 26 partials ⚠️
...f/fhir/utility/client/TerminologyServerClient.java 8.57% 32 Missing ⚠️
...a/org/opencds/cqf/fhir/utility/client/Clients.java 0.00% 9 Missing ⚠️
.../opencds/cqf/fhir/utility/EndpointCredentials.java 0.00% 7 Missing ⚠️
...ility/visitor/KnowledgeArtifactPackageVisitor.java 77.77% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #455      +/-   ##
============================================
+ Coverage     60.41%   60.63%   +0.22%     
- Complexity     3277     3429     +152     
============================================
  Files           327      329       +2     
  Lines         16870    17527     +657     
  Branches       2602     2699      +97     
============================================
+ Hits          10192    10628     +436     
- Misses         5545     5688     +143     
- Partials       1133     1211      +78

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sliver007
sliver007 requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct URL for the vsm-workflow-codes (formerly vsm-valueset-tag) CodeSystem throughout.

...hir-utility/src/main/java/org/opencds/cqf/fhir/utility/adapter/KnowledgeArtifactAdapter.java Outdated Show resolved Hide resolved
barhodes
barhodes requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@barhodes barhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested.

Also, consider making local methods in these classes protected rather than private so they can be overridden downstream if desired.

...lity/src/main/java/org/opencds/cqf/fhir/utility/visitor/KnowledgeArtifactPackageVisitor.java Show resolved Hide resolved
...hir-utility/src/main/java/org/opencds/cqf/fhir/utility/adapter/KnowledgeArtifactAdapter.java Outdated Show resolved Hide resolved
cqf-fhir-utility/src/main/java/org/opencds/cqf/fhir/utility/ResourceClassMapHelper.java Outdated Show resolved Hide resolved
...y/src/main/java/org/opencds/cqf/fhir/utility/visitor/r4/KnowledgeArtifactPackageVisitor.java Outdated Show resolved Hide resolved
...y/src/main/java/org/opencds/cqf/fhir/utility/visitor/r4/KnowledgeArtifactPackageVisitor.java Show resolved Hide resolved
@Chris0296
Refactor
7867860 
-make local methods protected
-throw unsupported error when invalid fhir version supplied
-move constants
-remove ResourceClassMapHelper
-change checkIfValueSetNeedsCondition to reflect removal of ResourceClassMapHelper
@Chris0296 Chris0296 requested a review from barhodes May 9, 2024 22:37
@Chris0296 Chris0296 requested a review from sliver007 May 14, 2024 14:32
sliver007
sliver007 approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@barhodes barhodes merged commit c0f8cd4 into cqframework:master May 14, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibaisi ibaisi ibaisi left review comments

@sliver007 sliver007 sliver007 approved these changes

@barhodes barhodes barhodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chris0296 @ibaisi @sliver007 @barhodes