Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue with Dstu3 Library identifier #446

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

barhodes
Copy link
Contributor

@barhodes barhodes commented Apr 8, 2024

Change VersionedIdentifiers helper method to allow for Dstu3 references which may be just resourceType/id due to how HAPI stores Dstu3 PlanDefinition resources.

Closes #445

Copy link

github-actions bot commented Apr 8, 2024

Formatting check succeeded!

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.59%. Comparing base (3c4c2d3) to head (7d16527).

Files Patch % Lines
...a/org/opencds/cqf/fhir/cql/LibraryConstructor.java 0.00% 1 Missing ⚠️
...org/opencds/cqf/fhir/cql/VersionedIdentifiers.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #446      +/-   ##
============================================
+ Coverage     59.44%   59.59%   +0.14%     
- Complexity     3189     3194       +5     
============================================
  Files           322      322              
  Lines         16552    16536      -16     
  Branches       2571     2570       -1     
============================================
+ Hits           9839     9854      +15     
+ Misses         5599     5567      -32     
- Partials       1114     1115       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 75de12e into master Apr 8, 2024
7 checks passed
@JPercival JPercival deleted the allow-reference-identifier branch April 8, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DSTU3 $apply error due to the way HAPI handles PlanDefinition library properties
2 participants