Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluator basis bug fix #442

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Evaluator basis bug fix #442

merged 5 commits into from
Apr 1, 2024

Conversation

Capt-Mac
Copy link
Contributor

closes https://github.com/alphora/dqm-platform/issues/543
closes https://github.com/alphora/dqm-platform/issues/554

MeasureEvaluator updates to split out how resource basis and boolean basis measures populate in measure populations

added additional testing for all measureTypes, reportTypes, basisTypes currently permitted with a minimal set of resources to simplify evaluation testing and validation

added additional validation around required population checks for Measures and added subject references for subjectList

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 94.80519% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 59.44%. Comparing base (3e75176) to head (a9b8b91).

Files Patch % Lines
...s/cqf/fhir/cr/measure/common/MeasureEvaluator.java 93.87% 0 Missing and 6 partials ⚠️
...qf/fhir/cr/measure/dstu3/Dstu3MeasureBasisDef.java 83.33% 0 Missing and 1 partial ⚠️
...ir/cr/measure/dstu3/Dstu3MeasureReportBuilder.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #442      +/-   ##
============================================
+ Coverage     59.23%   59.44%   +0.20%     
- Complexity     3175     3189      +14     
============================================
  Files           320      322       +2     
  Lines         16495    16552      +57     
  Branches       2564     2571       +7     
============================================
+ Hits           9771     9839      +68     
+ Misses         5606     5599       -7     
+ Partials       1118     1114       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 3c4c2d3 into master Apr 1, 2024
7 checks passed
@JPercival JPercival deleted the evaluator-basis-bug-fix branch April 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants