Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with item generation for hidden items #441

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

barhodes
Copy link
Contributor

With this change, when generating Questionnaire items from a Profile, if a differential element does not have a type, the type from the snapshot (if available) will be used. Alternatively, if the element has child elements defined the type is ignored and a group item is created for the children elements.

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 59.23%. Comparing base (a50e8eb) to head (7d524b1).

Files Patch % Lines
...questionnaire/generate/dstu3/ElementProcessor.java 87.50% 0 Missing and 1 partial ⚠️
...cr/questionnaire/generate/r4/ElementProcessor.java 87.50% 0 Missing and 1 partial ⚠️
...cr/questionnaire/generate/r5/ElementProcessor.java 87.50% 0 Missing and 1 partial ⚠️
...onnaireresponse/extract/ProcessDefinitionItem.java 95.23% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #441      +/-   ##
============================================
+ Coverage     59.15%   59.23%   +0.07%     
- Complexity     3163     3175      +12     
============================================
  Files           320      320              
  Lines         16496    16495       -1     
  Branches       2553     2564      +11     
============================================
+ Hits           9759     9771      +12     
+ Misses         5618     5606      -12     
+ Partials       1119     1118       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@rob-reynolds rob-reynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Expected results.

@barhodes barhodes merged commit 4ee24d3 into master Mar 21, 2024
7 checks passed
@barhodes barhodes deleted the fix-generate-hidden-items branch March 21, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants