Update 'glm' to v0.9.9.5 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update glm * removes old default for android * fixes 'unused' warnings in example
bkotzz
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed this guide
step by step carefully. Yes
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
I originally wanted to update to the newest glm package, however, there the install step is currently broken.
One of the travis-ci build steps fails, because the example had some unused variables. The example is taken from the glm repo. Some of the 'unused' warnings where already fixed there, so I took the changes from three. The other I just commented out. (Will be in the PR in hunter-testing)
In version prior to v.0.9.9.5 the android bug mentioned in ruslo#1595 is fixed. This is why I removed the
if(ANDROID)