Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency express to v4.19.2 [security] #2603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 27, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.17.1 -> 4.19.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location


Release Notes

expressjs/express (express)

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

v4.18.3

Compare Source

==========

v4.18.2

Compare Source

===================

v4.18.1

Compare Source

===================

  • Fix hanging on large stack of sync routes

v4.18.0

Compare Source

===================

v4.17.3

Compare Source

===================

v4.17.2

Compare Source

===================


Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Paris, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from JF-Cozy as a code owner March 27, 2024 06:20
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 2820522 to b1402f3 Compare March 27, 2024 14:23
Copy link

bundlemon bot commented Mar 27, 2024

BundleMon

Unchanged files (3)
Status Path Size Limits
dist/cozy-ui.min.css
20KB +10%
transpiled/react/stylesheet.css
17.92KB +10%
dist/cozy-ui.utils.min.css
10.74KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
transpiled/react/**
666.74KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

argos-ci bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 9 times, most recently from d6d7de7 to cc0b44a Compare April 3, 2024 13:53
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 6 times, most recently from 3fdf85a to c41d25b Compare April 9, 2024 15:02
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 6 times, most recently from 1e9eabf to 9d54e17 Compare April 18, 2024 08:13
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 9d54e17 to 05012af Compare April 18, 2024 10:28
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 4 times, most recently from 2b05e53 to d59f6e5 Compare April 25, 2024 19:28
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from e15a4f6 to ecf99cc Compare May 14, 2024 12:49
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 10 times, most recently from 76c7f49 to 1269cee Compare May 21, 2024 13:35
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 6 times, most recently from 0f255a5 to 5350e8e Compare May 28, 2024 15:15
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 5 times, most recently from a8f265e to ab76192 Compare May 29, 2024 21:37
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from ab76192 to f4048af Compare May 30, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants