Access to an app #82
Merged
Access to an app #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
440a50b
to
a031734
Compare
Closed
jinroh
reviewed
Nov 15, 2016
|
|
||
| instInterface, ok := c.Get("instance") | ||
| if !ok { | ||
| jsonapi.AbortWithError(c, jsonapi.InternalServerError(errors.New("no instance"))) |
jinroh
reviewed
Nov 15, 2016
| jsonapi.AbortWithError(c, jsonapi.NotFound(err)) | ||
| return | ||
| } | ||
| jsonapi.AbortWithError(c, jsonapi.InternalServerError(err)) |
aenario
approved these changes
Nov 16, 2016
| return err | ||
| } | ||
| err = createFile(pubdir, "index.html", "this is a file in public/") | ||
| if err != nil { |
There was a problem hiding this comment.
gometalinter & travis dislike this condition (if err != nil { return err }; return nil)
jinroh
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's work in progress. There are some known bugs and I should add some tests. But you can look at it