fix: IE11 does not handle HTML5 form attribute #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 68.12% 68.12%
=======================================
Files 128 128
Lines 12146 12146
=======================================
Hits 8274 8274
Misses 2858 2858
Partials 1014 1014Continue to review full report at Codecov.
|
|
@GoOz what do you think? |
GoOz
approved these changes
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internet Explorer and Edge do not support HTML5 form.
You can check it on https://html5test.com/
So, either we update html markup to wrap all inputs into the form element (this very PR), either we add some crappy JavaScript code to trigger the form submission on button click.