Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic sharing for files #526

Closed
wants to merge 1 commit into from

Conversation

paultranvan
Copy link
Contributor

This adds the possibility to define a permission on a dir_id, which is useful to share a directory through a selector.
Note this only handles one level of a hierarchy: full recursive permissions will probably require more work.

@codecov-io
Copy link

Codecov Report

Merging #526 into master will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   69.72%   69.85%   +0.13%     
==========================================
  Files         119      119              
  Lines        9870     9873       +3     
==========================================
+ Hits         6882     6897      +15     
+ Misses       2151     2141      -10     
+ Partials      837      835       -2
Impacted Files Coverage Δ
pkg/vfs/permissions.go 80% <0%> (-2.06%) ⬇️
pkg/workers/sharings/sharing_updates.go 54.87% <0%> (ø) ⬆️
pkg/sharings/send_mails.go 69.47% <0%> (ø) ⬆️
web/sharings/sharings.go 80.69% <0%> (+0.09%) ⬆️
pkg/workers/sharings/share_data.go 74.48% <0%> (+1.37%) ⬆️
pkg/workers/konnectors/konnector.go 70.09% <0%> (+1.86%) ⬆️
pkg/lock/simple_redis.go 74.5% <0%> (+9.8%) ⬆️
pkg/realtime/memtopic.go 100% <0%> (+19.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c4adc...001e4ac. Read the comment docs.

Copy link
Member

@nono nono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have permissions on a directory with all its children, including the recursivity thing

@paultranvan
Copy link
Contributor Author

@nono Ok I missed that. How can we declare them?

@aenario
Copy link
Contributor

aenario commented May 2, 2017

@Gara64 you just need to have the permissions on a folder and it will give permission for all its children. However, you need to use the vfs.Allows instead of permissions.Allow to validate them.

@paultranvan paultranvan closed this May 2, 2017
@paultranvan paultranvan deleted the sharing_dynamic_files branch April 10, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants