[VFS] Patch file meta #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2087329
to
521ee0c
Compare
24db20d
to
0e97c90
Compare
aenario
approved these changes
Oct 17, 2016
| newtags = data.Tags | ||
| } | ||
|
|
||
| newdoc, err = NewFileDoc( |
There was a problem hiding this comment.
Why not keeping oldpath and modifying the old doc in place ?
|
|
||
| // Context is used to convey the afero.Fs object along with the | ||
| // CouchDb database prefix. | ||
| type Context struct { |
There was a problem hiding this comment.
[Future] This could get complicated fast between gin.Context, couchdb.Prefix (+ some auth later), vfs.Context, middlewares.Instance. We should at least have some out-of-code doc on it, but better a proper discussion and normalisation.
0fc6910
to
32d2eb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
PATCH /files/:file-idroute to modify the metadata of a file, move it and rename it.I've also added a
vfs.Contextstruct to stop passing around fs / dbprefix values...